fix: Mismatch on Owner id for windows ami #93
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 27.88% 27.55% -0.34%
==========================================
Files 13 14 +1
Lines 1922 1938 +16
==========================================
- Hits 536 534 -2
- Misses 1386 1404 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
quixoticmonk
changed the title
| {"Name": "name", "Values": ["amazon-eks-node-*"]}, | ||
| {"Name": "is-public", "Values": ["true"]}, | ||
| ] | ||
| filters.append({"Name": "name", "Values": ["amazon-eks-node-*"]}) |
There was a problem hiding this comment.
We should change this to pull from the SSM parameters since this is the recommended approach. There may exist a newer AMI available based on these filters, but it may not be meant for consumption for various reasons (if the AMI is being recalled, etc.)
| {"Name": "name", "Values": ["ubuntu-eks/k8s_*"]}, | ||
| {"Name": "is-public", "Values": ["true"]}, | ||
| ] | ||
| filters.append({"Name": "name", "Values": ["ubuntu-eks/k8s_*"]}) |
Summary
Updated the eks image check and custom ami verification paths to not be locked against the owner-ids which were from
us-east-1. The owner-id specified for windows amis were not matching the actuals owner ids. This is an interim fix as described in #92 before rolling out additional changes.Errors noticed:
With the filtered values( including the owner-id) in describe images call, the ami ids were being flagged as custom amis.
Tested against a cluster with Windows node and based out of
us-east-2to verify that both the windows nodes and the owner id mapping were not causing any regressions.Resolves: #92
Changes
Removed the owner id references from all the filters as this is region dependent. The additional filters were modified for readability.
Note : With the filters removing the owner-ids which were previously there, the api call returns few more results than previously. This is to be updated in a later PR with the change in the model that is ongoing.
User experience
Fixes the issue mentioned in #92 . Existing amis in a region should be identified.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.