Skip to content

Feature/cleanup eventbridge #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmoutschen merged 2 commits into from
Feb 1, 2022
Merged

Feature/cleanup eventbridge #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10fd38d
feat(eventbridge): use DynConnector
hffmnn Feb 1, 2022
958fd7c
remove outdated comment
hffmnn Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions src/event_bus/eventbridge/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,19 @@ mod ext;
use ext::EventExt;

/// EventBridge bus implementation.
///
/// We have to pass a generic type parameter `C` for the underlying client,
/// restricted to something that implements the SmithyConnector trait so we can
/// use it with both the actual AWS SDK client and a mock implementation.
pub struct EventBridgeBus<C> {
client: Client<C>,
pub struct EventBridgeBus {
client: Client,
bus_name: String,
}

impl<C> EventBridgeBus<C>
where
C: aws_smithy_client::bounds::SmithyConnector,
{
pub fn new(client: Client<C>, bus_name: String) -> Self {
impl EventBridgeBus {
pub fn new(client: Client, bus_name: String) -> Self {
Self { client, bus_name }
}
}

#[async_trait]
impl<C> EventBus for EventBridgeBus<C>
where
C: aws_smithy_client::bounds::SmithyConnector,
{
impl EventBus for EventBridgeBus {
type E = Event;

/// Publish an event to the event bus.
Expand Down Expand Up @@ -89,7 +79,7 @@ mod tests {
use super::*;
use crate::{Event, Product};
use aws_sdk_eventbridge::{Client, Config, Credentials, Region};
use aws_smithy_client::test_connection::TestConnection;
use aws_smithy_client::{erase::DynConnector, test_connection::TestConnection};
use aws_smithy_http::body::SdkBody;

// Config for mocking EventBridge
Expand Down Expand Up @@ -132,7 +122,8 @@ mod tests {
.body(SdkBody::from("{}"))
.unwrap(),
)]);
let client = Client::from_conf_conn(get_mock_config().await, conn.clone());
let client =
Client::from_conf_conn(get_mock_config().await, DynConnector::new(conn.clone()));
let event_bus = EventBridgeBus::new(client, "test-bus".to_string());

// WHEN we send an event
Expand Down Expand Up @@ -167,7 +158,8 @@ mod tests {
.body(SdkBody::from("{}"))
.unwrap(),
)]);
let client = Client::from_conf_conn(get_mock_config().await, conn.clone());
let client =
Client::from_conf_conn(get_mock_config().await, DynConnector::new(conn.clone()));
let event_bus = EventBridgeBus::new(client, "test-bus".to_string());

// WHEN we send a batch of events
Expand Down Expand Up @@ -200,7 +192,8 @@ mod tests {
async fn test_send_events0() -> Result<(), Error> {
// GIVEN a mock EventBridge client
let conn: TestConnection<SdkBody> = TestConnection::new(vec![]);
let client = Client::from_conf_conn(get_mock_config().await, conn.clone());
let client =
Client::from_conf_conn(get_mock_config().await, DynConnector::new(conn.clone()));
let event_bus = EventBridgeBus::new(client, "test-bus".to_string());

// WHEN we send zero events
Expand Down Expand Up @@ -239,7 +232,8 @@ mod tests {
.body(SdkBody::from("{}"))
.unwrap(),
)]);
let client = Client::from_conf_conn(get_mock_config().await, conn.clone());
let client =
Client::from_conf_conn(get_mock_config().await, DynConnector::new(conn.clone()));
let event_bus = EventBridgeBus::new(client, "test-bus".to_string());

// WHEN we send 15 events
Expand Down
4 changes: 0 additions & 4 deletions src/store/dynamodb/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ mod ext;
use ext::AttributeValuesExt;

/// DynamoDB store implementation.
///
/// We have to pass a generic type parameter `C` for the underlying client,
/// restricted to something that implements the SmithyConnector trait so we can
/// use it with both the actual AWS SDK client and a mock implementation.
pub struct DynamoDBStore {
client: Client,
table_name: String,
Expand Down