Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript typings for making request's #293

Closed
MickL opened this issue Jul 13, 2021 · 2 comments
Closed

Add TypeScript typings for making request's #293

MickL opened this issue Jul 13, 2021 · 2 comments

Comments

@MickL
Copy link

MickL commented Jul 13, 2021

It would be nice if you add typings for use with TypeScript for making image requests. I barely see any documentation (e.g. what parameters the edits object can have) so typings would help A LOT.

E.g. here the object and all properties are any or unknown and when developing I dont know if there actually is a "grayscale" value or if it is named "greyscale" instead and whether it is a boolean or a string:

const imageRequest = JSON.stringify({
    bucket: “<myImageBucket>”
    key: “<myImage>.jpg”,
    edits: {
        grayscale: true
    }
})
@MickL MickL changed the title Add TypeScript typings Add TypeScript typings for making request's Jul 13, 2021
@beomseoklee
Copy link
Member

@MickL thanks for your feedback. We'll put TypeScript conversion into our backlog item.

@fisenkodv
Copy link
Contributor

@MickL, we have updated our solution, the issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.

You can refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants