Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS types for image request #341

Closed
And2s opened this issue Feb 22, 2022 · 3 comments
Closed

TS types for image request #341

And2s opened this issue Feb 22, 2022 · 3 comments

Comments

@And2s
Copy link

And2s commented Feb 22, 2022

Is your feature request related to a problem? Please describe.
Hello,

there is still no typing for edits property, I mean type ImageEdits = Record<string, any> is still a plain object with no typing...
Ref: https://github.com/aws-solutions/serverless-image-handler/blob/main/source/image-handler/lib/types.ts

Currently I can partially use types from @types/sharp 0.27.0 package e.g. for resize object.
But it does not feel right, I still have to experiment or look into the SIH source code to make a correct request.

Describe the feature you'd like
Implement full TS types for image request and export so that it would be available for use in Typescript projects.

Additional context
Related to #293

@fisenkodv
Copy link
Contributor

@And2s thank you for your feedback. We will look into it and add it to our backlog.

@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as closing-soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants