Use stack name in Service Catalog Application name for multiple cfn stack deployments #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows multiple stack deployments in the same account, region
gsingh04
changed the title
gsingh04
requested review from
a team,
dougtoppin,
CrypticCabub,
schana,
tmekari,
G-Lenz and
hearde
hearde
suggested changes
Feb 3, 2023
source/constructs/lib/common-resources/common-resources-construct.ts
Outdated
Show resolved
Hide resolved
hearde
approved these changes
Feb 3, 2023
CrypticCabub
approved these changes
Feb 3, 2023
Stack name is used in naming AppRegistry application and attribute group; which must not begin with aws. The change adds support for stack names starting with aws-*
gsingh04
force-pushed
the
release/v6.1.1
branch
from
1c8fca6 to
0c988bb
Compare
|
Should this be 4 separate commits? Or can it be all in one? |
dougtoppin
pushed a commit
that referenced
this pull request
Feb 7, 2023
…tack deployments (#438) * Add stack name to service catalog application This allows multiple stack deployments in the same account, region * Update cdk snapshot * Add changelog entry * Prepend AppRegistry application name with static name Stack name is used in naming AppRegistry application and attribute group; which must not begin with aws. The change adds support for stack names starting with aws-*
dougtoppin
added a commit
that referenced
this pull request
Feb 8, 2023
* Update CHANGELOG.md Correct release date * Remove unicode changes from backend, fix unicode support in demo-ui * Use stack name in Service Catalog Application name for multiple cfn stack deployments (#438) * Add stack name to service catalog application This allows multiple stack deployments in the same account, region * Update cdk snapshot * Add changelog entry * Prepend AppRegistry application name with static name Stack name is used in naming AppRegistry application and attribute group; which must not begin with aws. The change adds support for stack names starting with aws-* * Update to v6.1.1, set release date, include PR link --------- Co-authored-by: Doug Toppin <toppaws@amazon.com> Co-authored-by: garvit singh <garvits@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add support for multiple stack deployments in the account, region with different Service Catalog AppRegistry Application
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.