Misra updates #67
Misra updates #67
Conversation
defined value instead. Moving rules around in the misra.config file, and then updating the MISRA.md file for new format. Last change was inclusion of the DISABLE_LOGGING define to remove assert() when building for coverity.
…nning coverity scan
| To find the violation references in the source files run grep on the source code | ||
| with ( Assuming rule 11.4 violation; with justification in point 2 ): | ||
| ``` | ||
| grep 'MISRA Ref 11.1.4' . -rI |
There was a problem hiding this comment.
grep is typically only found on unix operating systems by default. could we not just add the grep output in a table here? why make users run it themselves?
There was a problem hiding this comment.
Copied the grep from FreeRTOS+TCP MISRA changes as seen here, as I was told to make the formatting of these files/MISRA changes the same across the various repos.
Since this repo currently doesn't have any suppressed violations I see nothing wrong with removing the grep and just stating that in the file for now, I had left it there to be consistent was all.
I imagine the general idea for the inclusion of the grep instead of the table is to handle line changes when commits happen. For example corePKCS11 has upwards of 50-60 inline suppressions, so adding a table to that would require a bit of overhead to ensure it stays accurate.
MISRA violations.
Swapping to explicit if statement comparisons to get around this.
Changes to MISRA.md to reflect new format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.