MeetingManager throws original error name from getUserMedia call #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #888 :
We wrap the original error from
getUserMediawith the generalError. It make it difficult for builders to handle the actual error. With this change,startAudioInputDevice,startVideoInputDevice, andsetupDeviceLabelTriggerofMeetingManagernow throw errors with the original errornamereturned by thegetUserMediacall.Description of changes:
startAudioInputDevice,startVideoInputDevice, andsetupDeviceLabelTriggerofMeetingManagernow throw errors with the original errornamereturned by thegetUserMediacall.For example, before this change the
errorthrown bystartVideoInputDevicewas:No it is:
Testing
Have you successfully run
npm run build:releaselocally?Yes
How did you test these changes?
startAudioInputDevice,startVideoInputDevicemanually.setupDeviceLabelTrigger.startAudioInputDevice,startVideoInputDeviceand verify the error log.If you made changes to the component library, have you provided corresponding documentation changes?
No doc needs to be changed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.