Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add await for toggleContentShare #946

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add await for toggleContentShare #946

merged 1 commit into from
Apr 5, 2024

Conversation

ltrung
Copy link
Contributor

@ltrung ltrung commented Apr 5, 2024

Issue #:
Currently in toggleContentShare we do not await for the JS SDK API thus, if the APIs fail, callers would not be able to handle it.

Description of changes:

Testing

  1. Have you successfully run npm run build:release locally?
    Yes
  2. How did you test these changes?
    Add unit tests
  3. If you made changes to the component library, have you provided corresponding documentation changes? N/A
    By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ltrung ltrung requested a review from a team as a code owner April 5, 2024 01:38
@ltrung ltrung merged commit f86eb0d into main Apr 5, 2024
2 checks passed
@ltrung ltrung deleted the await-content-share branch April 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michhyun1 michhyun1 michhyun1 approved these changes

@xuesichao xuesichao xuesichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltrung @xuesichao @michhyun1