Add changeBackgroundReplacementImage to BackgroundReplacementProvider #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need to squash the two commits |
dingyishen-amazon
force-pushed
the
background-replacement-image
branch
from
fec720c
to
3cf9db9
Compare
dingyishen-amazon
force-pushed
the
background-replacement-image
branch
2 times, most recently
from
0f8e17e
to
bab26f6
Compare
michhyun1
previously approved these changes
Aug 1, 2024
dingyishen-amazon
force-pushed
the
background-replacement-image
branch
2 times, most recently
from
8d6fa1b
to
7b3afb0
Compare
dingyishen-amazon
force-pushed
the
background-replacement-image
branch
from
7b3afb0
to
9fab705
Compare
georgezy-amzn
approved these changes
Aug 1, 2024
xuesichao
approved these changes
Aug 1, 2024
ltrung
reviewed
Aug 2, 2024
ltrung
reviewed
Aug 2, 2024
| @@ -40,6 +40,9 @@ interface BackgroundReplacementProviderState { | |||
| ) => Promise<DefaultVideoTransformDevice>; | |||
| isBackgroundReplacementSupported: boolean | undefined; | |||
| backgroundReplacementProcessor: BackgroundReplacementProcessor | undefined; | |||
| changeBackgroundReplacementImage: ( | |||
There was a problem hiding this comment.
Can we add unit test for this file?
ltrung
reviewed
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
Add
changeBackgroundReplacementImagefunction in theBackgroundReplacementProviderto enable the functionality of changing the background replacement image.Testing
Have you successfully run
npm run build:releaselocally?Yes
How did you test these changes?
Make corresponding changes in the demo app, and test with it. Demo Video attached:
https://github.com/user-attachments/assets/20c92ebf-2d25-4375-870b-b4e00bf2cdbd
If you made changes to the component library, have you provided corresponding documentation changes?
No, will add the documentation change after the demo changes are merged since the documentation example should be similar with demo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.