Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LocalAudioOutputProvider to not bind an audio element on startup when isAudioOn set is false #965

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tr00st
Copy link

@tr00st tr00st commented Sep 16, 2024

Issue #964:

Description of changes:
Updated LocalAudioOutputProvider to check the value of isAudioOn when hooked on to audioVideo being initialized. It now won't bind the audio if it's already been disabled before startup.

Testing

  1. Have you successfully run npm run build:release locally?
    No - it immediately drops out with Didn't find any new commit. Exiting process.

Guessing it's because I've already pushed to my fork? Wasn't mentioned in CONTRIBUTING.md so I didn't attempt to run it until creating the PR. Regular npm run build runs fine though.

  1. How did you test these changes?
    Unit tests rerun fine - no tests exist for this component, and not sure how to hook them up given the need to bind audio etc.

Tested locally by installing the dev version into our application. See issue for reproduction steps.

  1. If you made changes to the component library, have you provided corresponding documentation changes?

None made - should continue to operate as documented.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tr00st tr00st marked this pull request as ready for review September 16, 2024 09:57
@tr00st tr00st requested a review from a team as a code owner September 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant