Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content share resume issue #640

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

georgezy-amzn
Copy link
Collaborator

ℹ️ Description

  • Fix the issue that the screen share doesn't resume after reconnection

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

Verified by following the steps below:

  • Join a meeting
  • Turn on screen share (in-app or broadcast)
  • Turn off internet
  • Verify the screen share is gone from remote attendee
  • Turn back on internet
  • Verify the screen share resumes correctly from remote attendee

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

  • Unit tests pass
  • Build SDK against simulator with release options
  • Build SDK against device with release options
  • Build SDK against simulator with debug options
  • Build SDK against device with debug options
  • Test Demo against simulator with SDK (debug build) in workspace
  • Test Demo against device with SDK (debug build) in workspace
  • Test DemoObjC against simulator with SDK (debug build) in workspace
  • Test DemoObjC against device with SDK (debug build) in workspace
  • Test Demo against simulator with SDK.framework (release build)
  • Test Demo against device with SDK.framework (release build)
  • Test DemoObjC against simulator with SDK.framework (release build)
  • Test DemoObjC against device with SDK.framework (release build)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@georgezy-amzn georgezy-amzn merged commit 84713c7 into development Feb 9, 2024
4 checks passed
@georgezy-amzn georgezy-amzn deleted the content-share-delegate-fix branch February 9, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants