Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate audio RED worker before removing reference #2960

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

hensmi-amazon
Copy link
Contributor

Issue #: #2956

Description of changes:
Title. Putting my trust in the issue's mitigation description :).

Testing:
Joined a meeting and made sure nothing exploded.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
No

Checklist:

  1. Have you successfully run npm run build:release locally?
    y

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
    n

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
    n

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ltrung
ltrung previously approved these changes Sep 27, 2024
ltrung
ltrung previously approved these changes Sep 30, 2024
@ltrung
Copy link
Contributor

ltrung commented Sep 30, 2024

Seem like have not run npm run doc

@hensmi-amazon hensmi-amazon merged commit 5cacbb6 into main Oct 2, 2024
10 checks passed
@hensmi-amazon hensmi-amazon deleted the red-worker-ref branch October 2, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants