Change test failure to echo a warning when checking k8s version dependencies #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisguo
requested review from
movence and
mitali-salvi
and removed request for
movence and
mitali-salvi
mitali-salvi
reviewed
Aug 5, 2024
lisguo
changed the title
mitali-salvi
reviewed
Aug 9, 2024
mitali-salvi
previously approved these changes
Sep 6, 2024
sky333999
approved these changes
Sep 11, 2024
mitali-salvi
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Upstream opentelemetry-operator does not always ensure k8s dependencies are up to date when supporting a new version of k8s. Our current compatibility model depends on upstream, so this check is a blocker for future versions.
Example run: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/10356859832
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.