Add integration tests for JMX. #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mitali-salvi
force-pushed
the
jmx-merge
branch
from
69c96cc to
c8e6e2f
Compare
Paramadon
reviewed
Oct 11, 2024
Paramadon
reviewed
Oct 11, 2024
integration-tests/manifests/cmd/validate_instrumentation_vars.go
Outdated
Show resolved
Hide resolved
Paramadon
reviewed
Oct 11, 2024
integration-tests/manifests/cmd/validate_instrumentation_vars.go
Outdated
Show resolved
Hide resolved
Paramadon
reviewed
Oct 11, 2024
integration-tests/manifests/cloudwatch-agent-daemonset-no-app-signals.yaml
Show resolved
Hide resolved
Paramadon
reviewed
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds integration tests to check if enabling annotations adds expected JMX environmental variables for
app_signalsand without.Testing
make testSee passing tests in
Checks: https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/11283409192?pr=245.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.