Use replicaset name as part of service name fallback #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably migrate the TestChooseServiceName test: https://github.com/open-telemetry/opentelemetry-operator/blob/main/pkg/instrumentation/sdk_test.go#L2416 |
lisguo
approved these changes
Oct 16, 2024
bjrara
approved these changes
Oct 16, 2024
lisguo
added a commit
that referenced
this pull request
Oct 28, 2024
…er (#262) * added agent server port as default port on CW agent (#234) * Attach service name source as resource attribute to operator (#235) * Add service name source for instrumentation and workload * Change service name source attribute naming * Fix unit tests for pod mutators * Simplify service name source determination * Fix incorrect refactor of source constants * Use replicaset name as part of service name fallback (#249) * Use replicaset name as part of service name fallback * Add chooseServiceName unit test * Change import statement ordering * Fix service name source being added multiple times for multiple injections (#254) * added fix to not override the service name source for multiple auto-inject --------- Co-authored-by: POOJA REDDY NATHALA <poojardy@amazon.com> Co-authored-by: zhihonl <61301537+zhihonl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upstream otel-collector uses replicaset name as service name as part of the service name fallback strategy. Our operator does not do that yet. https://github.com/open-telemetry/opentelemetry-operator/blob/main/pkg/instrumentation/sdk.go#L420
In this PR, we add change to parse replicaset name as service name when available.
Test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.