Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Target Allocator] Enable Deployment and Daemonset modes for Agent #253

Merged
merged 2 commits into from
Oct 21, 2024
Merged

[Target Allocator] Enable Deployment and Daemonset modes for Agent #253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2e8d05
Changes error to warning
okankoAMZ Oct 17, 2024
e128f40
addressed comment
okankoAMZ Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/v1alpha1/collector_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func (c CollectorWebhook) validate(r *AmazonCloudWatchAgent) (admission.Warnings

// validate target allocation
if r.Spec.TargetAllocator.Enabled && r.Spec.Mode != ModeStatefulSet {
return warnings, fmt.Errorf("the OpenTelemetry Collector mode is set to %s, which does not support the target allocation deployment", r.Spec.Mode)
warnings = append(warnings, fmt.Sprintf("The OpenTelemetry Collector mode is set to %s, we do not recommend enabling Target Allocator when not running as a StatefulSet", r.Spec.Mode))
}

// validate Prometheus config for target allocation
Expand Down