Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Application Signals .NET runtime metrics config #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bjrara
Copy link
Contributor

@bjrara bjrara commented Dec 19, 2024

Description of changes:
This PR allows customers to configure dotnet runtime metrics collection at cluster level.

Test

Configuration

--auto-instrumentation-config={"dotnet":{"runtime_metrics":{"enabled":"true"},"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"runtime_metrics":{"enabled":"true"},"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"runtime_metrics":{"enabled":"true"},"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"}}}

Result

kubectl get po payment-service-dotnet-67b7c6c679-mjz5p -oyaml | grep RUNTIME -A 1
    - name: OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED
      value: "true"

Configuration

--auto-instrumentation-config={"dotnet":{"runtime_metrics":{"enabled":"false"},"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"runtime_metrics":{"enabled":"true"},"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"runtime_metrics":{"enabled":"true"},"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"}}}

Result

kubectl get po payment-service-dotnet-67b7c6c679-k4hgl -oyaml | grep RUNTIME -A 1
    - name: OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED
      value: "false"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant