Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Test: Fix and update release testing #51

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

majanjua-amzn
Copy link
Collaborator

@majanjua-amzn majanjua-amzn commented Dec 15, 2023

Change log:

  • Fixing release testing by updating the override to work with EKS addon
  • Updating test to use enablement script from aws-observability/application-signals-demo
  • Added API calls before test run to speed up test like in other repos
  • Removed caller-workflow-name input
  • Pull test resources from aws-observability/aws-otel-java-instrumentation to remove code duplication
  • Updating some of the versions for actions like checkout to better match the workflow in the ADOT repo
  • Updated the image verification steps to show the operator image that is being used in the pods
  • Updated the image verification steps to fail if the operator image did not change after patching

The change to patch the deployment is based on template defined here: link

Test fails if image hasn't changed: run
Test passes if image is changed to a functional one: run

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@majanjua-amzn majanjua-amzn added bug Something isn't working enhancement New feature or request labels Dec 15, 2023
@majanjua-amzn majanjua-amzn self-assigned this Dec 15, 2023
harrryr
harrryr previously approved these changes Dec 15, 2023
Copy link

@thpierce thpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a new test run with the next revision to show the latest changes work as expected.

.github/workflows/appsignals-e2e-test.yml Outdated Show resolved Hide resolved
@majanjua-amzn majanjua-amzn force-pushed the release-test-fix branch 15 times, most recently from 0931fce to c2e9620 Compare December 18, 2023 21:25
lisguo
lisguo previously approved these changes Dec 19, 2023
.github/workflows/appsignals-e2e-test.yml Show resolved Hide resolved
.github/workflows/appsignals-e2e-test.yml Show resolved Hide resolved
Copy link
Contributor

@nathalapooja nathalapooja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more description to the github workflow what exactly this test is doing?

@majanjua-amzn majanjua-amzn merged commit 07cf186 into main Dec 19, 2023
1 check passed
@mitali-salvi mitali-salvi deleted the release-test-fix branch February 1, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants