Fix failing JMX tests #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice findings! |
zhihonl
reviewed
Nov 11, 2024
| @@ -46,7 +46,7 @@ func (t *JMXTomcatJVMTestRunner) GetAgentConfigFileName() string { | |||
| } | |||
|
|
|||
| func (t *JMXTomcatJVMTestRunner) GetAgentRunDuration() time.Duration { | |||
| return 2 * time.Minute | |||
| return 10 * time.Minute | |||
There was a problem hiding this comment.
Is 10 minutes necessary here or can we reduce it to 5 minutes or less? or is that still too short to collect this metric. Asking since sleeping 10 minutes for a test to run slow down the testing process.
There was a problem hiding this comment.
I think 5 is a good balance—will make this change and keep an eye on the tests
jefchien
reviewed
Nov 11, 2024
test/metric_value_benchmark/agent_configs/jmx_tomcat_jvm_config.json
Outdated
Show resolved
Hide resolved
zhihonl
approved these changes
Nov 12, 2024
|
Run #11749486690 (integration test run from original PR) |
zhihonl
approved these changes
Nov 12, 2024
jefchien
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We have failing JMX tests throughout out integration tests for multiple OSes. Here is a failed run that shows the test failing on these metrics in a previous run—specifically the garbage collection and tomcat metrics.
Description of changes
metrics_collection_intervalto 60 seconds to better capture infrequent metrics (likejvm.gc.collections.elapsedandjvm.gc.collections.count)License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
I ran the integration tests in the
amazon-cloudwatch-agentrepo under the fix-JMX-integ-tests branch. That branch of the main repo is configured to run integration tests using this branch of the test repo. Here is the run: Run #11802640395