Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency for pr #346

Merged
merged 12 commits into from
Jan 31, 2022
Merged

Add concurrency for pr #346

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e671a58
add concurrency for pr build and test
Jan 27, 2022
02ba51c
add concurrency for integration test
Jan 27, 2022
32c8bca
fix concurrency for pr build
Jan 27, 2022
e9be61f
fix concurrency for pr build
Jan 27, 2022
e48d5c4
add paths ignores and reduce branches to use master only
Jan 27, 2022
6c478d7
change to use github workflow instead of literal string
Jan 28, 2022
a63d3ba
change to use whole path instead of abs path
khanhntd Jan 28, 2022
c4196b9
change order of path ignore
khanhntd Jan 28, 2022
495615c
change order of path ignore
khanhntd Jan 28, 2022
885935b
delete space
khanhntd Jan 28, 2022
5d07540
fix pattern for build test windows
khanhntd Jan 28, 2022
f3f39f6
change fail fast to false
khanhntd Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/build-test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,22 @@
name: build-and-test-windows
on:
push:
branches: [ main, master ]
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep main, it's there for future transition to "main" instead of "master"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that in my review. I did see that the other build yaml doesn't have main either though, so they'll both need to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this when developing the EKS integration test.


paths-ignore:
- '**.md'
- '.github/**'
- '!.github/workflows/**'
khanhntd marked this conversation as resolved.
Show resolved Hide resolved

pull_request:
types: [opened, synchronize, reopened, ready_for_review]
workflow_dispatch:

concurrency:
SaxyPandaBear marked this conversation as resolved.
Show resolved Hide resolved
group: ${{ github.workflow }}-${{ github.ref_name }}
cancel-in-progress: true

jobs:
windows-unittest:
runs-on: windows-latest
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,22 @@ on:
push:
branches:
- master

paths-ignore:
- '**.md'
- '.github/**'
- '!.github/workflows/build-*'


pull_request:
types: [opened, synchronize, reopened, ready_for_review]
workflow_dispatch:

jobs:
concurrency:
group: ${{ github.workflow }}-${{ github.ref_name }}
cancel-in-progress: true

jobs:
build:
name: Build
runs-on: ${{ matrix.os }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/integrationTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
- master
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref_name }}
cancel-in-progress: true
SaxyPandaBear marked this conversation as resolved.
Show resolved Hide resolved

jobs:
EC2LinuxIntegrationTest:
name: 'EC2LinuxIntegrationTest'
Expand Down