Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Service Discovery: Fixup implicit network mode #385

Merged
merged 1 commit into from
Mar 8, 2022
Merged

ECS Service Discovery: Fixup implicit network mode #385

merged 1 commit into from
Mar 8, 2022

Commits on Feb 28, 2022

  1. ECS Service Discovery: Fixup implicit network mode 

    I originally submitted aws#330
with the goal of correcting the service discovery behavior of a task when its
definition did not specify a network mode.

Very graciously, @javabrett submitted a fix for this via
aws#335. Upon testing this out
today, I found out we're not _quite_ there.

Crucially, when network mode is undefined in a task definition, it will parse as
`nil`, not the empty string. Correcting this in our unit tests reveals the
behavior isn't working as desired, since the `getPrivateIp` function isn't
properly handling the `nil` case. I believe this addresses the issue.
    Will Myers committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    c70d7bb View commit details
    Browse the repository at this point in the history