add environment file to api #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhlee-aws
reviewed
Feb 25, 2020
| EnvironmentFiles: []*ecsacs.EnvironmentFile{ | ||
| { | ||
| Value: strptr("s3://bucketName/envFile"), | ||
| Type: strptr("s3"), |
There was a problem hiding this comment.
do we need to add test for when this is not s3?
There was a problem hiding this comment.
customers wouldn't be able to register a task def for values other than s3 currently based on backend logic.. do you think that's still needed as a test on our side?
yhlee-aws
approved these changes
Feb 25, 2020
fenxiong
reviewed
Feb 25, 2020
fenxiong
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds environmentFile to api container stuff
Implementation details
Testing
make test
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.