Add /etc/pki directory to appnet agent's bind mounts #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
force-pushed
the
sparrc-sc-pki-mount
branch
from
9208019 to
38ca72c
Compare
This is the path to the host's PKI directory. The appnet agent container needs this directory mounted so that it can access the host's PKI directory for the purpose of utilizing any special CA certs that the underlying EC2 instance has configured.
sparrc
force-pushed
the
sparrc-sc-pki-mount
branch
from
38ca72c to
158bb5f
Compare
Yiyuanzzz
approved these changes
Dec 4, 2024
danehlim
approved these changes
Dec 4, 2024
sparrc
added a commit
to sparrc/amazon-ecs-agent
that referenced
this pull request
Dec 5, 2024
sparrc
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the path to the host's PKI directory. The appnet agent container needs
this directory mounted so that it can access the host's PKI directory for the
purpose of utilizing any special CA certs that the underlying EC2 instance has
configured.
Without this change the appnet agent is not able to operate and the service
connect feature does not work in situations where the EC2 instance has
non-standard CA certs configured.
Testing
New tests cover the changes: no, modified existing unit test
Description for the changelog
Enhancement: Add /etc/pki directory to appnet agent's bind mounts for service connect
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.