Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused GetPublishMetricsTicker method from stats engine #4455

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Remove unused GetPublishMetricsTicker method from stats engine #4455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions agent/stats/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ type Engine interface {
GetTaskHealthMetrics() (*ecstcs.HealthMetadata, []*ecstcs.TaskHealth, error)
GetPublishServiceConnectTickerInterval() int32
SetPublishServiceConnectTickerInterval(int32)
GetPublishMetricsTicker() *time.Ticker
}

// DockerStatsEngine is used to monitor docker container events and to report
Expand Down Expand Up @@ -1083,10 +1082,6 @@ func (engine *DockerStatsEngine) SetPublishServiceConnectTickerInterval(publishS
engine.publishServiceConnectTickerInterval = publishServiceConnectTickerInterval
}

func (engine *DockerStatsEngine) GetPublishMetricsTicker() *time.Ticker {
return engine.publishMetricsTicker
}

func (engine *DockerStatsEngine) getEBSVolumeMetrics(taskArn string) []*ecstcs.VolumeMetric {
task, err := engine.resolver.ResolveTaskByARN(taskArn)
if err != nil {
Expand Down
15 changes: 0 additions & 15 deletions agent/stats/mock/engine.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading