Add EFS volume support to ECS Params for task. #1056
Conversation
bvtujo
left a comment
bvtujo
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the contribution!
| } | ||
|
|
||
| // TODO: revert to "LATEST" when latest refers to 1.4.0 | ||
| if ecsParams != nil && len(ecsParams.TaskDefinition.EFSVolumes) != 0 { |
There was a problem hiding this comment.
we should only be setting the platform version when the launch type is FARGATE, otherwise EC2 tasks will fail.
See this PR for how we implement this check and test it in the service context.
|
@tatsuya-ogawa thank you for contributing! We made a fix to the service logic for EFS support since #1019 , so if you can update the check and add tests as described, we should be good to accept this. |
|
Hi @tatsuya-ogawa-- Thanks so much for the contribution. I've picked your commit up in #1076 and added test functionality. I'm going to close this for now as your change is represented in the new PR. Please let me know if you have any questions! |
3 participants
Related to #1019.
Even in the task definition,
I added determination of platform version so that efs can be used.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.