This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Add integration tests that follow our EC2 tutorial #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
requested review from
PettitWesley,
SoManyHs,
allisaurus and
piradeepk
Contributor
Author
|
Output from CodeBuild: |
|
|
||
| // Then | ||
| stdout.Stdout(out).TestHasAllSubstrings(t, []string{ | ||
| "Started container", |
Contributor
There was a problem hiding this comment.
I wish there was an easy way to guarantee that the right number of tasks are running.
I think this is fine for now though.
Contributor
There was a problem hiding this comment.
I see this is done using ps in the actual integ test 👍🏻
| // Increase the number of running tasks | ||
| cmd.TestTaskScale(t, project, 2) | ||
| ecs.TestListTasks(t, conf.ClusterName, 2) | ||
| cmd.TestPsRunning(t, project, 4) |
Contributor
There was a problem hiding this comment.
The numbers here confuse me... after TestTaskUp, why are 2 containers expected in PS?
And after scaling to 2 tasks, why are 4 containers expected in PS?
Contributor
Author
There was a problem hiding this comment.
Yeah, I can totally understand the confusion.
If you look at the compose file, we have two containers listed out. So that 1 task with two containers. When we scale the number of tasks to 2, then we end up with 4 running containers in the cluster.
I'll add comments explaining this in the integ test.
|
|
||
| // TestListTasks validates that a cluster has the expected number of | ||
| // tasks by periodically querying against ECS. | ||
| func TestListTasks(t *testing.T, clusterName string, wantedSize int) { |
allisaurus
reviewed
May 1, 2019
| ./scripts/build_binary.sh ./bin/local | ||
| @echo "Running integration tests..." | ||
| go test -tags integ -v ./ecs-cli/integ/e2e/... | ||
| go test -timeout 60m -tags integ -v ./ecs-cli/integ/e2e/... |
Contributor
There was a problem hiding this comment.
just curious: do we know how long these tests are taking to run on average? wondering if we can track length of test runs in CloudWatch so we can keep an eye on things as we add more tests.
Contributor
Author
There was a problem hiding this comment.
After making the tests run in parallel, it came down to ~11 mins from ~17mins.
The default go test timeout is 10m, that's why i had to override that value. I picked 60m to be consistent with the codebuild timeout.
allisaurus
reviewed
May 2, 2019
ecs-cli/integ/e2e/ec2_task_test.go
Outdated
|
|
||
| func createEC2TutorialComposeFile(t *testing.T) string { | ||
| content := ` | ||
| version: '3' |
Contributor
There was a problem hiding this comment.
what do you think about using version: 2 compose for this test? We support both but parsing takes diff code paths, so using v2 here and keeping v3 in the Fargate test would increase total line coverage.
Contributor
Author
There was a problem hiding this comment.
Great suggestion, updated!
allisaurus
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Add integration tests that follow our EC2 tutorial (https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-cli-tutorial-ec2.html)
Testing
Documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.