This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix expectation and use of SocketsConfig_t::pAlpnProtos #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run checks |
1 similar comment
|
/bot run checks |
|
/bot run checks |
|
/bot run checks |
3 similar comments
|
/bot run checks |
|
/bot run checks |
|
/bot run checks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detailed in #3516, the expectation and use of
pAlpnProtoswas that of a string, but it's propagated to lower layers as an array of strings instead. Incorrectly calculating the number of separate protocols as the demos setpAlpnProtosas a string, yet transport_secure_sockets.c#L267 assumes the number of separate protocols is the length of this string.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.