Fix for file logging errors in windows environments #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
approved these changes
Nov 18, 2024
andreachild
force-pushed
the
achild/windowsFixes
branch
from
513b502 to
ff0be1c
Compare
-replaced : and . characters in log file name with - as windows does not allow these characters in file names -replaced usage of pino.transport with pino.multistream which resolved issue of log file being created with no content
andreachild
force-pushed
the
achild/windowsFixes
branch
from
ff0be1c to
25d7449
Compare
sophiadt
pushed a commit
to Bit-Quill/amazon-neptune-for-graphql
that referenced
this pull request
Nov 20, 2024
-replaced : and . characters in log file name with - as windows does not allow these characters in file names -replaced usage of pino.transport with pino.multistream which resolved issue of log file being created with no content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for file logging related errors in windows environments:
:and.characters in log file name with-as windows does not allow these characters in file namespino.transportwithpino.multistreamwhich resolved issue of log file being created with no content