Replace AuthTokens.basic with NeptuneAuthToken in OpenCypher #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryn5
force-pushed
the
ryan/neptune-auth-token
branch
from
dca9ea9
to
3378bb1
Compare
xiazcy
approved these changes
Apr 17, 2024
|
This is a workaround to resolve token refresh issue that was brought up in #258, specific to Neo4j driver 4.4+. |
xiazcy
reviewed
Apr 17, 2024
src/main/java/software/aws/neptune/opencypher/OpenCypherIAMRequestGenerator.java
Show resolved
Hide resolved
xiazcy
reviewed
Apr 18, 2024
src/main/java/software/aws/neptune/opencypher/OpenCypherIAMRequestGenerator.java
Outdated
Show resolved
Hide resolved
ryn5
force-pushed
the
ryan/neptune-auth-token
branch
from
3378bb1
to
65d66f6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatical renewal of AWS Signature v4 authentication tokens is currently not supported, which means that after the signature expires (often in 5 minutes), the driver will fail to authenticate, and subsequent requests will fail.
Description
This change updates the implementation of InternalAuthToken to NeptuneAuthToken, taken from AWS Neptune documentation, so that the signature can be automatically renewed even if the connection is broken.
Related Issue
#258
Additional Reviewers