Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tableau Data Preview Error Fixes #58

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

lyndonbauto
Copy link
Contributor

@lyndonbauto lyndonbauto commented Nov 19, 2021

Summary

Tableau Data Preview Error Fixes

Description

[1] Tableau Data Preview was giving an error that COUNT was not found
[2] After the COUNT was found issue was resolved (by adding it to dialect file) it gave an error with the query that was being executed. The query in question was a SUM() query. This exposed an issue with () queries in the sql-gremlin library, which is corrected in these changes.
[3] Alexey also noted that AVG was reported as unsupported in Tableau, so I added it to the dialect file as well.

Related Issue

https://bitquill.atlassian.net/browse/AN-894

Additional Reviewers

@birschick-bq
@lyndonb-bq
@xiazcy
@simonz-bq
@alexey-temnikov
@kylepbit

@lyndonbauto lyndonbauto added this to the Neptune JDBC Driver GA milestone Nov 19, 2021
@lyndonbauto lyndonbauto requested a review from a team November 19, 2021 22:54
Copy link
Contributor

@kylepbit kylepbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any mention of SUM here, but I do in the PR description?

@lyndonbauto
Copy link
Contributor Author

@kylepbit

I don't see any mention of SUM here, but I do in the PR description?

The sum issue was actually just an aggregate literal issue that is fixed in code here:
https://github.com/aws/amazon-neptune-jdbc-driver/pull/58/files#diff-fdad9775fe9a63de32f52cdf4b1419d9fb5a8052c4944d7f88f69ff0504cba08R86
I will update the description because it is misleading.

@lyndonbauto lyndonbauto linked an issue Nov 19, 2021 that may be closed by this pull request
@lyndonbauto lyndonbauto merged commit 2ca88d6 into develop Nov 19, 2021
@lyndonbauto lyndonbauto deleted the lyndon/AN-894-dta-preview-error branch November 19, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tableau data preview window does not work in 2021.3
4 participants