Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minimal Linux installation filetype #234

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

brandonskiser
Copy link
Contributor

Description of changes:

  • Update the file type of update packages for Linux minimal installations to tarZst instead of tarGz. The release for v1.4.6 (included in v1.5.0) has broken update logic for Linux minimal installs where the app will always download a tarGz and attempt to unpack using zstd. This change will revert back to the previous behavior of always using tarZst.
  • Add some extra debug statements when updating.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brandonskiser brandonskiser requested a review from a team as a code owner December 11, 2024 19:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 12.28%. Comparing base (66b08bd) to head (b355e0f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/fig_install/src/linux.rs 0.00% 2 Missing ⚠️
crates/fig_install/src/index.rs 0.00% 1 Missing ⚠️
crates/fig_install/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   12.28%   12.28%           
=======================================
  Files        2246     2246           
  Lines      191070   191074    +4     
  Branches   174985   174989    +4     
=======================================
+ Hits        23470    23473    +3     
- Misses     166401   166405    +4     
+ Partials     1199     1196    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 changed the title Fix minimal Linux installation filetype fix: minimal Linux installation filetype Dec 11, 2024
@grant0417 grant0417 merged commit 4d757c4 into main Dec 11, 2024
20 checks passed
@grant0417 grant0417 deleted the bskiser/linux-minimal-update-fix branch December 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants