Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra lines in inline recommendation #446

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

grant0417
Copy link
Member

@grant0417 grant0417 commented Jan 15, 2025

Description of changes:
This resolves #445, currently additional lines are potentially being returned which breaks the inline recommendations. This PR uses a Regex to remove any additional content with the pattern of: {next_line_number}\s+.*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@grant0417 grant0417 requested a review from a team as a code owner January 15, 2025 23:12
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 34.78261% with 45 lines in your changes missing coverage. Please review.

Project coverage is 12.52%. Comparing base (2bac442) to head (e6bfe16).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/figterm/src/inline/mod.rs 34.78% 44 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   12.50%   12.52%   +0.02%     
==========================================
  Files        2235     2234       -1     
  Lines      190308   190381      +73     
  Branches   174896   174969      +73     
==========================================
+ Hits        23796    23850      +54     
- Misses     165307   165328      +21     
+ Partials     1205     1203       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grant0417 grant0417 merged commit ab0ef29 into aws:main Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird inline completions
3 participants