Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use windows proxy for https #415

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from
Open

use windows proxy for https #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agent/proxyconfig/proxy_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,10 @@ func ParseProxySettings(log log.T, proxy string) ProxySettings {
HttpsProxy: https,
}

// If no [<scheme>=] is provided http is the default option
// If no [<scheme>=] is provided all schemes are handled
if https == nil && http == nil {
result.HttpProxy = other
result.HttpsProxy = other
} else if https != nil && http == nil {
result.HttpProxy = other
} else if https == nil && http != nil {
Expand Down