Update domainjoin_unix_script to fix SUSE issues #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was already variables for the SUSE distribution release and service pack but the SUSEConect to enable PackageHub was hardcoded for 15.1. Newer releases have been out for years with 15.4 being recently released in 06/2022. It's not clear to me why NetworkManager was being installed. This should not be used on SLE Server deployments. NetworkManager is only supported by SUSE for desktop workloads with SLED or the Workstation extension. All server certifications are done with wicked as the network configuration tool and using NetworkManager may invalidate them. NetworkManager is not supported by SUSE for any server workloads.
|
Sorry, I saw this late. |
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There was already variables for the SUSE distribution release and service pack but the SUSEConect to enable PackageHub was hardcoded for 15.1. Newer releases have been out for years with 15.4 being recently released in 06/2022.
It's not clear to me why NetworkManager was being installed. This should not be used on SLE Server deployments. NetworkManager is only supported by SUSE for desktop workloads with SLED or the Workstation extension. All server certifications are done with wicked as the network configuration tool and using NetworkManager may invalidate them. NetworkManager is not supported by SUSE for any server workloads.
https://doc.opensuse.org/documentation/leap/reference/html/book-reference/cha-nm.html#
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.