Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for driver fail with newer golang such as v1.11 #240

Closed
nak3 opened this issue Nov 26, 2018 · 0 comments · Fixed by #241
Closed

unit test for driver fail with newer golang such as v1.11 #240

nak3 opened this issue Nov 26, 2018 · 0 comments · Fixed by #241

Comments

@nak3
Copy link
Contributor

nak3 commented Nov 26, 2018

Issue

Unit test for driver fail with golang v1.11.

Steps to reproduce

$ go version
go version go1.11.2 linux/amd64

$ GOOS=linux CGO_ENABLED=1 go test -v -cover -race -timeout 10s ./plugins/routed-eni/driver
# github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni/driver
plugins/routed-eni/driver/driver.go:184: Wrapf call has arguments but no formatting directives
FAIL	github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni/driver [build failed]

Additionl info

golang 1.10.3 works fine. (So, I'm sorry if this project does not support golang v1.11 for now.)

$ go version
go version go1.10.3 linux/amd64

$ GOOS=linux CGO_ENABLED=1 go test -cover -race -timeout 10s ./plugins/routed-eni/driver
ok  	github.com/aws/amazon-vpc-cni-k8s/plugins/routed-eni/driver	1.018s	coverage: 62.3% of statements

Proposal fix #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant