Add formatter to errors.Wrapf in driver #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test for driver fail with golang v1.11 due to `Wrapf call has arguments but no formatting directives` error. This patch adds formatting directives to errors.Wrapf in driver.go for the fix. Additionally, this PR includes tiny fix in driver.go. Hence it changes overall: - to add formatter to errors.Wrapf - to use errors.Wrapf() in run() func. - to fix one typo
mogren
approved these changes
Nov 26, 2018
| @@ -181,7 +180,7 @@ func setupNS(hostVethName string, contVethName string, netnsPath string, addr *n | |||
| // Clean up if hostVeth exists. | |||
| if oldHostVeth, err := netLink.LinkByName(hostVethName); err == nil { | |||
| if err = netLink.LinkDel(oldHostVeth); err != nil { | |||
| return errors.Wrapf(err, "setup NS network: failed to delete old hostVeth", hostVethName) | |||
| return errors.Wrapf(err, "setup NS network: failed to delete old hostVeth %q", hostVethName) | |||
There was a problem hiding this comment.
Ah, thanks for fixing this! I noticed the compile issues with 1.11, but didn't have time to find the cause of the problem yet. Had planned to look at it this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for driver fail with golang v1.11 due to
Wrapf call has arguments but no formatting directiveserror. This patch addsformatting directives to errors.Wrapf in driver.go for the fix.
Additionally, this PR includes tiny fix in driver.go. Hence it changes
overall:
Issue #, if available:
Fixes #240
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.