Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation correction for AWS_VPC_K8S_CNI_RANDOMIZESNAT #380

Closed
hgokavarapuz opened this issue Apr 5, 2019 · 1 comment · Fixed by #556
Closed

Documentation correction for AWS_VPC_K8S_CNI_RANDOMIZESNAT #380

hgokavarapuz opened this issue Apr 5, 2019 · 1 comment · Fixed by #556

Comments

@hgokavarapuz
Copy link

Documentation seems to be wrong for AWS_VPC_K8S_CNI_RANDOMIZESNAT which states use it when AWS_VPC_K8S_CNI_EXTERNALSNAT=true is set. But setting the value to true means The SNAT iptables rule and off-VPC IP rule are not applied, and these rules are removed if they have already been applied. AWS_VPC_K8S_CNI_RANDOMIZESNAT should be used only when the AWS_VPC_K8S_CNI_EXTERNALSNAT=false. Here is the code link

https://github.com/taylorb-syd/amazon-vpc-cni-k8s/blob/e59edf200179e82d6cd141d8e394f4d4b7978bb4/pkg/networkutils/network.go#L338

@InAnimaTe
Copy link

Agreed, definitely contradicts itself as if SNAT isn't enabled, there's no reason to tune the options passed to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants