Add ipamd changes for sg support #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
add-ipamd-changes-for-sg-support
branch
2 times, most recently
from
d47f26c
to
cd5cc93
Compare
mogren
changed the title
mogren
force-pushed
the
add-ipamd-changes-for-sg-support
branch
4 times, most recently
from
e3f21ce
to
d067f21
Compare
| if err != nil { | ||
| if k8serror.IsNotFound(err) { | ||
| log.Warn("Send AddNetworkReply: pod not found") | ||
| return &rpc.DelNetworkReply{Success: true}, nil |
There was a problem hiding this comment.
Does CNI takes care if you send empty IP in the response?
There was a problem hiding this comment.
Yes, if we can't parse the IP returned, we just log a warning and exit. From the del function:
deletedPodIP := net.ParseIP(r.IPv4Addr)
if deletedPodIP != nil {
.
.
.
} else {
log.Warnf("Container %s did not have a valid IP %s", args.ContainerID, r.IPv4Addr)
}
return nil
}
d067f21
to
9073605
Compare
|
Note: Since the CircleCI tests run in my account, the results do not get reported correctly in the PR: |
mogren
force-pushed
the
add-ipamd-changes-for-sg-support
branch
from
9073605
to
9b83dbb
Compare
SaranBalaji90
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up to #1125, will rebase once that PR is merged.
Description of changes:
aws-nodeand return the needed values to the CNI binaryBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.