Rebase of exising IPv6 PR #1199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
add-ipv6
branch
2 times, most recently
from
97f3b7a to
738b05f
Compare
PR to add IPv6 support to the AWS VPC CNI. This change adds ASSIGN_IPV4 and ASSIGN_IPV6 CNI config env vars, that default to true and false respecitvely. Co-authored-by: Angus Lees <gus@inodes.org> (cherry picked from commit e845584)
|
Closing the PR since starting v1.10.0 aws-vpc-cni support IPV6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue(s) this PR fixes:
#893
What does this PR do:
Add initial IPv6 support. This is a rebase of #956 by @anguslees, with some additional changes.
Some of these changes can be extracted, for example the added utility function to read boolean ENV variables, or the Containernetworking dependency updates.
Testing:
No manual testing yet, this is a work in progress.
Current e2e tests: https://app.circleci.com/pipelines/github/mogren/amazon-vpc-cni-k8s/910/workflows/c7f6cadf-40ac-456c-82a2-3cc377c35dff/jobs/1845
Automation added to e2e:
None yet
Will this break upgrades and downgrades. Has it been tested?:
Not tested yet
Will this change require CNI config only changes?:
Yes, eventually
Does this PR introduce a user-facing change?:
Yes, eventually
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.