CNI IT to test for version upgrade/downgrade #1795

Shreya027 · 2021-12-16T23:00:59Z

What type of PR is this?
feature

Which issue does this PR fix:
Adds integration tests for testing upgrade/downgrade using user provided initial and final CNI version. Pod traffic, host networking and service connectivity test are run, first on applying initial addon version and again on applying final addon version to test for successful upgrade/downgrade.

What does this PR do / Why do we need it:

Takes parameterized input with $CNI_INITIAL_VERSION and $CNI_FINAL_VERSION provided as follows:

ginkgo -v --failOnPending -- \                                                    
 --cluster-kubeconfig=$KUBECONFIG \
 --cluster-name=$CLUSTER_NAME \
 --aws-region=$AWS_REGION \
 --aws-vpc-id=$VPC_ID \
 --ng-name-label-key=$NG_NAME_LABEL_KEY \
 --ng-name-label-val=$NG_NAME_LABEL_VAL \
 --initial-version=$CNI_INITIAL_VERSION \
 --final-version=$CNI_FINAL_VERSION

Added additional addon wrapper functions in eks.go under framework folders that can be re-used for addon related utilities
Added code for applying/deleting/describing addons in ginkgo tests
Added code for running pod traffic, service connectivity and host networking tests in upgrade testing

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
#694

Testing done on this change:

Ran all the 3 test files that gave all tests passed in at least one of the runs:

/amazon-vpc-cni-k8s/test/integration-new/cni-version-testing/cni_version_service_connectivity_test.go:191
------------------------------
STEP: deleting test namespace

Ran 10 of 10 Specs in 1563.561 seconds
SUCCESS! -- 10 Passed | 0 Failed | 0 Pending | 0 Skipped

amazon-vpc-cni-k8s/test/integration-new/cni-version-testing/cni_version_host_networking_test.go:168
------------------------------
STEP: deleting test namespace

Ran 8 of 8 Specs in 1011.273 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped

If PD and other values not correctly configured as master config manifest, the tests might show failures.
Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

No, adds testing code

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cgchinmay · 2021-12-21T20:19:27Z

Do we need a separate folder ? wondering this why this cannot be part of the existing cni folder.

cgchinmay

I think we should restructure test files so that we minimize the code duplication.

test/integration-new/cni-version-testing/cni_version_host_networking_test.go

abhipth · 2022-01-13T23:48:20Z

@Shreya027 thanks for the PR, before I dive deep into the PR had a couple of questions

Is this test intended to test the active production system i.e the published add-ons? We have something similar here . But it's good to write it in Ginkgo.
How does this scale, let's say we want to plug-in and plug-out new tests in upgrade/downgrade scenarios.
How can we utilize this when doing a new release (an addon that is not yet published).

Shreya027 · 2022-01-16T02:33:51Z

Hi Abhinav, I have hopefully addressed your questions below:

Yes it can be used for published add-ons. Ideally in an add-on release pipeline in the future. For instance, a pipeline that updates the default VPC CNI version for eks clusters
Yes, it should be easy to scale as long as the existing tests are modular. It should a simple addition to existing test calls as below:

Context("when testing host networking on xxxx version", func() {
		HostNetworkingTest()
		PodTrafficTest()
		ServiceConnectivityTest()
		...
		....
	})

I don't think we can utilize this for an addon that is not yet published. Because the code uses Addon Functions that seem to use published add-ons.

Let me know if you have any further questions, thanks !

cgchinmay · 2022-01-22T01:58:46Z

The below test is currently flaky, however it has had 8/8 tests passed in one of the runs

Could you elaborate on this ? Why is it flaky ?

cgchinmay · 2022-01-22T02:09:09Z

test/framework/resources/aws/services/eks.go

@@ -23,7 +23,10 @@ import (
 type EKS interface {
 	DescribeCluster(clusterName string) (*eks.DescribeClusterOutput, error)
 	CreateAddon(addon string, clusterName string) (*eks.CreateAddonOutput, error)
+	CreateAddonWithVersion(addon string, clusterName string, addonVersion string) (*eks.CreateAddonOutput, error)


If only change is the version, then I think we should create an AddonInput struct and pass it to the method, instead of creating a new method only for version. That way it would be easy to extend to other methods.

I created a separate func because we have to add an additional parameter aws.String("OVERWRITE"), for ResolveConflicts in case a version is specified in the eks.go file. If we have one function, we will have to perform a check there and modify the struct to set ResolveConflicts parameter.

test/integration-new/cni/cni_version_test.go

Shreya027 · 2022-02-01T23:01:48Z

The below test is currently flaky, however it has had 8/8 tests passed in one of the runs
Could you elaborate on this ? Why is it flaky ?

By flaky, I mean some of the test errors seem to be transient. They run successfully on test re-runs. However, my code hasn't changed any of the test logic, it just runs the tests by making calls to them on upgrade/downgrade. By test here, I am referring to the CNI tests called on upgrade/downgrade

cgchinmay · 2022-02-02T20:22:36Z

test/framework/resources/aws/services/eks.go

 }

 type defaultEKS struct {
 	eksiface.EKSAPI
 }

+type CreateAddOnParams struct {


nit: may be rename to AddOnInput so that it can be extended for Describe, Delete as well if needed. Also add a short comment to describe the usage of this struct.

cgchinmay · 2022-02-02T20:50:38Z

test/framework/resources/aws/services/eks.go

+
+	AddonName    string `locationName:"addonName" type:"string" required:"true"`
+	ClusterName  string `location:"uri" locationName:"name" min:"1" type:"string" required:"true"`
+	AddonVersion string `locationName:"addonVersion" type:"string"`


Add example of Version format in comments. like v1.7.5 or v1.7.5-eksbuild.1

cgchinmay · 2022-02-02T22:06:43Z

test/integration-new/cni/cni_version_test.go

+	By("getting the current addon")
+	describeAddonOutput, err = f.CloudServices.EKS().DescribeAddon("vpc-cni", f.Options.ClusterName)
+	if err == nil {
+		fmt.Printf("By applying addon %s\n", versionName)


Change it to By instead . remove Print calls

cgchinmay · 2022-02-03T23:49:02Z

test/integration-new/cni/cni_version_test.go

+			Expect(err).ToNot(HaveOccurred())
+
+			_, err = f.CloudServices.EKS().DescribeAddon("vpc-cni", f.Options.ClusterName)
+			for err == nil {


This could lead to an infinite loop. I think we should refactor this logic. We should have some timeout

cgchinmay · 2022-02-04T07:00:53Z

test/integration-new/cni/cni_version_test.go

+	var status = ""
+
+	By("waiting for  addon to be ACTIVE")
+	for status != "ACTIVE" {


I think this can be extracted to a utility function similar to daemonset.go. So this logic can be extended.

cgchinmay · 2022-02-04T07:12:41Z

test/integration-new/cni/cni_version_test.go

+	}
+
+	//Set the WARM_ENI_TARGET to 0 to prevent all pods being scheduled on secondary ENI
+	k8sUtils.AddEnvVarToDaemonSetAndWaitTillUpdated(f, "aws-node", "kube-system",


What are the default settings when you apply an addon ?Just want to know why we need to ensure these env settings ?

cgchinmay · 2022-02-04T07:14:26Z

test/integration-new/cni/cni_version_test.go

+	Context("when testing host networking on final version", func() {
+		HostNetworkingTest()
+		PodTrafficTest()
+		ServiceConnectivityTest()


I think these 3 functions are 3 different kinds of tests, so should be separated out in 3 Contexts ? would like to know your thoughts

cgchinmay

Just few comments, rest looks good. Thanks 👍

Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade

cgchinmay · 2022-02-14T08:29:39Z

Closing this PR, refer this instead: #1861

Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (aws#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com>

Refactored code Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (aws#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh

Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (aws#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (aws#1864) * Added new instances * Updated test readme * needed rebase * formatting

…#1861) * Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (#1864) * Added new instances * Updated test readme * needed rebase * formatting * remove all references to integration-new migrate to ginkgo v2 in addon test files * fix maxIPPerInterface count on pod_networking_suite * Increase default deployment ready timeout Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com>

* Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test

…aws#1861) * Refactored code Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (aws#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (aws#1864) * Added new instances * Updated test readme * needed rebase * formatting * remove all references to integration-new migrate to ginkgo v2 in addon test files * fix maxIPPerInterface count on pod_networking_suite * Increase default deployment ready timeout Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com>

* Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (aws#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test

* Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Updated Readme

* 1.10.3 release artifacts (#1962) * Stale PR and issue cleanup wrkflow (#1964) * fix image name during build (#1968) * add event recorder utils to raise aws-node pod events (#1536) * refactor uploader scripts (#1972) * Fix cni panic due to pod.Annotations is a nil map (#1974) Co-authored-by: Relk Li <relk@maicoin.com> * chart: Add extraVolumes and extraVolumeMounts (#1949) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Add the new command in the section of CNI Plugin Sequence (#1813) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Bump github.com/containernetworking/cni from 0.8.0 to 0.8.1 (#1966) Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 0.8.0 to 0.8.1. - [Release notes](https://github.com/containernetworking/cni/releases) - [Commits](containernetworking/cni@v0.8.0...v0.8.1) --- updated-dependencies: - dependency-name: github.com/containernetworking/cni dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Update README to highlight containerd.sock edge case with EKS AMI. (#1884) * Update README to highlight containerd.sock edge case with EKS AMI. * Updated Instructions as per review. * add cni release test script (#1971) * Multus release manifest (#1984) * release manifest for Multus v3.8.0-eksbuild.1 * minor change to Readme * Added Tests for validating Multus Installation (#1811) * Added Tests for validating Multus Installation Added missing files Refactored code Tried to make it modular and extensible. * Deleted redundant file * Fixed compilation issues * fixed minor error * Added script to trigger Multus tests (will be used by prow job) * remove multus installation logic from ginkgo * remove redundant changes * Cleaned up run-multus-tests helper script * Updated Readme for running multus tests Added few checks in canary helper script * revert changes to canary.sh * Pass tag as an argument * Updated Readme * Updated tag for multus tests to use latest image * Port new integration tests (#1928) * Minor changes to run-integration-tests Added integration-new framework tests * Modified run-integration-tests to use new integration tests * reverted redundant changes * Merge integration with integration-new * increase timeout (#1985) fix syntax for ginkgo-v2 * Added configurable flag to create test nodes with arm64 and containerd runtime (#1977) * Cleanup binary file (#1987) * log error in ipamd on api server timeout (#1988) * Refactored code and Added cni addon upgrade/downgrade regression test (#1861) * Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (#1864) * Added new instances * Updated test readme * needed rebase * formatting * remove all references to integration-new migrate to ginkgo v2 in addon test files * fix maxIPPerInterface count on pod_networking_suite * Increase default deployment ready timeout Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com> * Remove generation of calico manifests (#1905) * cni manifest upgrade downgrade test (#1863) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Update golang to Go 1.18 (#1991) * Update CNI Plugins to v1.1.1 (#1997) * Update release manifests for VPC CNI v1.11.2 (#2001) (#2002) * Enable Calico on ARM64 and add configureable flags for Calico installation (#2004) * Enable Calico on ARM64 and add configureable flags for Calico installation * Add v to Calico version in release test script * fix integration test script (#1998) * Updated dependencies (#2012) * Fix readme (#2013) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Updated Readme * Merge fix-ginkgo to master (#2014) * fix path failure * seperate makefile for test Co-authored-by: abhipth <abhipth@amazon.com> * Multus manifest for release v3.9.0-eksbuild.1 (#2016) * Updating new instances - p4de (#2018) * Updating new instances * fix formatting * Fix go build failure with v6 networking suite. (#2020) * Update README.md (#2021) * Fix Go build for ipamd test package. (#2023) * Fix Go build for ipamd test package. * Fix format with make format * Fix go build for cni test package. (#2024) * Prevent allocate/free ENIs when node is marked noSchedule (#1927) * Prevent allocate/free ENIs when node is marked noSchedule * Update UTs * Re-use logger instance (#2029) * Re-use logger instance - Existing logger initialization constructed different logger instances upon call to Get() method. - Fixed the initailiation logic to re-use the logger instance. * Added unit tests for logger initialization fix Co-authored-by: M00nF1sh <yyyng@amazon.com> Co-authored-by: Sushmitha Ravikumar <58063229+sushrk@users.noreply.github.com> Co-authored-by: Relk Li <YiJiun.Li.C@gmail.com> Co-authored-by: Relk Li <relk@maicoin.com> Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Shuntaro Azuma <azush.work@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Senthil Kumaran <senthilx@amazon.com> Co-authored-by: cgchinmay <cgadgil@amazon.com> Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com> Co-authored-by: Hao Zhou <haouc@users.noreply.github.com> Co-authored-by: abhipth <abhipth@amazon.com> Co-authored-by: Prasad Jivane <prasad.jivane@walchandsangli.ac.in>

* 1.10.3 release artifacts (#1962) * Stale PR and issue cleanup wrkflow (#1964) * fix image name during build (#1968) * add event recorder utils to raise aws-node pod events (#1536) * refactor uploader scripts (#1972) * Fix cni panic due to pod.Annotations is a nil map (#1974) Co-authored-by: Relk Li <relk@maicoin.com> * chart: Add extraVolumes and extraVolumeMounts (#1949) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Add the new command in the section of CNI Plugin Sequence (#1813) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Bump github.com/containernetworking/cni from 0.8.0 to 0.8.1 (#1966) Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 0.8.0 to 0.8.1. - [Release notes](https://github.com/containernetworking/cni/releases) - [Commits](containernetworking/cni@v0.8.0...v0.8.1) --- updated-dependencies: - dependency-name: github.com/containernetworking/cni dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Update README to highlight containerd.sock edge case with EKS AMI. (#1884) * Update README to highlight containerd.sock edge case with EKS AMI. * Updated Instructions as per review. * add cni release test script (#1971) * Multus release manifest (#1984) * release manifest for Multus v3.8.0-eksbuild.1 * minor change to Readme * Added Tests for validating Multus Installation (#1811) * Added Tests for validating Multus Installation Added missing files Refactored code Tried to make it modular and extensible. * Deleted redundant file * Fixed compilation issues * fixed minor error * Added script to trigger Multus tests (will be used by prow job) * remove multus installation logic from ginkgo * remove redundant changes * Cleaned up run-multus-tests helper script * Updated Readme for running multus tests Added few checks in canary helper script * revert changes to canary.sh * Pass tag as an argument * Updated Readme * Updated tag for multus tests to use latest image * Port new integration tests (#1928) * Minor changes to run-integration-tests Added integration-new framework tests * Modified run-integration-tests to use new integration tests * reverted redundant changes * Merge integration with integration-new * increase timeout (#1985) fix syntax for ginkgo-v2 * Added configurable flag to create test nodes with arm64 and containerd runtime (#1977) * Cleanup binary file (#1987) * log error in ipamd on api server timeout (#1988) * Refactored code and Added cni addon upgrade/downgrade regression test (#1861) * Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (#1864) * Added new instances * Updated test readme * needed rebase * formatting * remove all references to integration-new migrate to ginkgo v2 in addon test files * fix maxIPPerInterface count on pod_networking_suite * Increase default deployment ready timeout Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com> * Remove generation of calico manifests (#1905) * cni manifest upgrade downgrade test (#1863) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Update golang to Go 1.18 (#1991) * Update CNI Plugins to v1.1.1 (#1997) * Update release manifests for VPC CNI v1.11.2 (#2001) (#2002) * Enable Calico on ARM64 and add configureable flags for Calico installation (#2004) * Enable Calico on ARM64 and add configureable flags for Calico installation * Add v to Calico version in release test script * fix integration test script (#1998) * Updated dependencies (#2012) * Fix readme (#2013) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Updated Readme * Merge fix-ginkgo to master (#2014) * fix path failure * seperate makefile for test Co-authored-by: abhipth <abhipth@amazon.com> * Multus manifest for release v3.9.0-eksbuild.1 (#2016) * Updating new instances - p4de (#2018) * Updating new instances * fix formatting * Fix go build failure with v6 networking suite. (#2020) * Update README.md (#2021) * Fix Go build for ipamd test package. (#2023) * Fix Go build for ipamd test package. * Fix format with make format * Fix go build for cni test package. (#2024) * Prevent allocate/free ENIs when node is marked noSchedule (#1927) * Prevent allocate/free ENIs when node is marked noSchedule * Update UTs * Re-use logger instance (#2029) * Re-use logger instance - Existing logger initialization constructed different logger instances upon call to Get() method. - Fixed the initailiation logic to re-use the logger instance. * Added unit tests for logger initialization fix * fix addOn version api for beta (#2034) * Update yaml.v3 package dependency (#2036) * Update yaml.v3 package dependency Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Co-authored-by: M00nF1sh <yyyng@amazon.com> Co-authored-by: Sushmitha Ravikumar <58063229+sushrk@users.noreply.github.com> Co-authored-by: Relk Li <YiJiun.Li.C@gmail.com> Co-authored-by: Relk Li <relk@maicoin.com> Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Shuntaro Azuma <azush.work@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Senthil Kumaran <senthilx@amazon.com> Co-authored-by: cgchinmay <cgadgil@amazon.com> Co-authored-by: Hao Zhou <haouc@users.noreply.github.com> Co-authored-by: abhipth <abhipth@amazon.com> Co-authored-by: Prasad Jivane <prasad.jivane@walchandsangli.ac.in>

* 1.10.3 release artifacts (#1962) * Stale PR and issue cleanup wrkflow (#1964) * fix image name during build (#1968) * add event recorder utils to raise aws-node pod events (#1536) * refactor uploader scripts (#1972) * Fix cni panic due to pod.Annotations is a nil map (#1974) Co-authored-by: Relk Li <relk@maicoin.com> * chart: Add extraVolumes and extraVolumeMounts (#1949) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Add the new command in the section of CNI Plugin Sequence (#1813) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Bump github.com/containernetworking/cni from 0.8.0 to 0.8.1 (#1966) Bumps [github.com/containernetworking/cni](https://github.com/containernetworking/cni) from 0.8.0 to 0.8.1. - [Release notes](https://github.com/containernetworking/cni/releases) - [Commits](containernetworking/cni@v0.8.0...v0.8.1) --- updated-dependencies: - dependency-name: github.com/containernetworking/cni dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Update README to highlight containerd.sock edge case with EKS AMI. (#1884) * Update README to highlight containerd.sock edge case with EKS AMI. * Updated Instructions as per review. * add cni release test script (#1971) * Multus release manifest (#1984) * release manifest for Multus v3.8.0-eksbuild.1 * minor change to Readme * Added Tests for validating Multus Installation (#1811) * Added Tests for validating Multus Installation Added missing files Refactored code Tried to make it modular and extensible. * Deleted redundant file * Fixed compilation issues * fixed minor error * Added script to trigger Multus tests (will be used by prow job) * remove multus installation logic from ginkgo * remove redundant changes * Cleaned up run-multus-tests helper script * Updated Readme for running multus tests Added few checks in canary helper script * revert changes to canary.sh * Pass tag as an argument * Updated Readme * Updated tag for multus tests to use latest image * Port new integration tests (#1928) * Minor changes to run-integration-tests Added integration-new framework tests * Modified run-integration-tests to use new integration tests * reverted redundant changes * Merge integration with integration-new * increase timeout (#1985) fix syntax for ginkgo-v2 * Added configurable flag to create test nodes with arm64 and containerd runtime (#1977) * Cleanup binary file (#1987) * log error in ipamd on api server timeout (#1988) * Refactored code and Added cni addon upgrade/downgrade regression test (#1861) * Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Renamed package name for adddon tests removed unnecessary changes Fixed replica count for MTU and Veth test in host networking Updated ENI/IP limits file for newly added instances (#1864) * Added new instances * Updated test readme * needed rebase * formatting * remove all references to integration-new migrate to ginkgo v2 in addon test files * fix maxIPPerInterface count on pod_networking_suite * Increase default deployment ready timeout Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com> * Remove generation of calico manifests (#1905) * cni manifest upgrade downgrade test (#1863) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Update golang to Go 1.18 (#1991) * Update CNI Plugins to v1.1.1 (#1997) * Update release manifests for VPC CNI v1.11.2 (#2001) (#2002) * Enable Calico on ARM64 and add configureable flags for Calico installation (#2004) * Enable Calico on ARM64 and add configureable flags for Calico installation * Add v to Calico version in release test script * fix integration test script (#1998) * Updated dependencies (#2012) * Fix readme (#2013) * Added upgrade/downgrade script template Refactored code Addon upgrade/downgrade test similar to #1795 Added tests for addon upgrade/downgrade Changed DEFAULT version Added addon status checks Fetch latest addon version for given K8s Cluster Update kops cluster config used in weekly tests (#1862) * Change to kops cluster creation scripts * Add logging for retry attempt * Switch kops cluster to use docker container runtime Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> Added upgrade/downgrade test for custom cni-manifest-file Added missing files remove upgrade-downgrade.sh * Add eks.go file , deleted by mistake * Extract apply manifest logic in common Remove redundant code * Add PD traffic test for cni upgrade downgrade test * Updated Readme * Merge fix-ginkgo to master (#2014) * fix path failure * seperate makefile for test Co-authored-by: abhipth <abhipth@amazon.com> * Multus manifest for release v3.9.0-eksbuild.1 (#2016) * Updating new instances - p4de (#2018) * Updating new instances * fix formatting * Fix go build failure with v6 networking suite. (#2020) * Update README.md (#2021) * Fix Go build for ipamd test package. (#2023) * Fix Go build for ipamd test package. * Fix format with make format * Fix go build for cni test package. (#2024) * Prevent allocate/free ENIs when node is marked noSchedule (#1927) * Prevent allocate/free ENIs when node is marked noSchedule * Update UTs * Re-use logger instance (#2029) * Re-use logger instance - Existing logger initialization constructed different logger instances upon call to Get() method. - Fixed the initailiation logic to re-use the logger instance. * Added unit tests for logger initialization fix * fix addOn version api for beta (#2034) * Update yaml.v3 package dependency (#2036) * Update yaml.v3 package dependency * Increase cpu requests limit (#2038) - Porting changes from release-1.10 branch made in PR #1749 * fix ipamd integration failures and cleanup (#2039) * fix integration test failures and cleanup * README update * cleanup info logs in event recorder and test script (#2043) * add nodeSelector to cni-metrics-helper test deployment and update image tag (#2047) * fix makefile path in canary test script (#2051) * disable arm build (#2052) * Updated changelog for 1.11.3 release (#2053) Co-authored-by: Vikas Basavaraj Mallapura <“5373156+vikasmb@users.noreply.github.com”> * Updating master branch config files to release 1.11.3 (#2055) * Updated changelog for 1.11.3 release * Image tag and chart version update for 1.11.3 release (#2050) Co-authored-by: Vikas Basavaraj Mallapura <“5373156+vikasmb@users.noreply.github.com”> (cherry picked from commit ff42a83) Co-authored-by: Vikas Basavaraj Mallapura <“5373156+vikasmb@users.noreply.github.com”> * update aws-node clusterrole permissions (#2058) * Fix minor typo on documentation (#2059) s/varibales/variables/ * multus manifest for release v3.9.0-eksbuild.2 (#2057) * Setting AWS_VPC_K8S_CNI_RANDOMIZESNAT to the default value (#2028) Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * Fixing prefixes per ENI value in example (#2060) Prefixes per ENI in row 6 should be 1 not 3. Co-authored-by: Jayanth Varavani <1111446+jayanthvn@users.noreply.github.com> * IPAMD optimizations and makefile changes (#1975) * IPAMD optimizations and makefile changes * Minor comments * Removed IMDS dependency * fix test * fix test * fix test-format * Updated new instances (#2062) * Updated new instances * fix format Co-authored-by: M00nF1sh <yyyng@amazon.com> Co-authored-by: Sushmitha Ravikumar <58063229+sushrk@users.noreply.github.com> Co-authored-by: Relk Li <YiJiun.Li.C@gmail.com> Co-authored-by: Relk Li <relk@maicoin.com> Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Shuntaro Azuma <azush.work@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Senthil Kumaran <senthilx@amazon.com> Co-authored-by: cgchinmay <cgadgil@amazon.com> Co-authored-by: Vikas Basavaraj <5373156+vikasmb@users.noreply.github.com> Co-authored-by: Hao Zhou <haouc@users.noreply.github.com> Co-authored-by: abhipth <abhipth@amazon.com> Co-authored-by: Prasad Jivane <prasad.jivane@walchandsangli.ac.in> Co-authored-by: Vikas Basavaraj Mallapura <“5373156+vikasmb@users.noreply.github.com”> Co-authored-by: Guillaume Delacour <guillaume.delacour@gmail.com> Co-authored-by: Venkata Gunapati <gvsukumar@gmail.com> Co-authored-by: Muhammed Karakas <karakas@amazon.com>

Shreya027 requested a review from a team as a code owner December 16, 2021 23:00

Shreya027 force-pushed the upgrade-branch branch from eca6551 to d148fad Compare December 17, 2021 21:56

Shreya027 requested a review from abhipth December 17, 2021 23:45

cgchinmay reviewed Dec 21, 2021

View reviewed changes

test/integration-new/cni-version-testing/cni_version_host_networking_test.go Outdated Show resolved Hide resolved

Shreya027 force-pushed the upgrade-branch branch 2 times, most recently from 1385d05 to 295a2ed Compare January 11, 2022 18:20

Shreya027 requested a review from cgchinmay January 12, 2022 00:24

abhipth requested a review from a team January 13, 2022 23:50

cgchinmay reviewed Jan 22, 2022

View reviewed changes

test/integration-new/cni/cni_version_test.go Show resolved Hide resolved

cgchinmay reviewed Feb 2, 2022

View reviewed changes

Shreya Anil Naik added 13 commits February 2, 2022 13:26

Add framework DescribeAddon and DescribeAddonVersion fns

7f4e745

Add initial upgrade testing code

f66e2fb

Add initial upgrade testing code

78a658d

Add refactoring of code

58cc1c6

Add changes in refactoring

6b2692a

Add upgrade testing code refactored to ginkgo modules

24ba038

Add separate fn for addon create, Revise comments

dc0fcff

Add minor fixes

1df42b4

Fix formmating

4b7e555

Add reformatting changes

f2d5d31

Add code refactoring to reduce code duplication

782f386

Add minor code refactoring

d4851df

Add go formatting changes

d3c1efa

Add comments and function renaming

fa4f247

Shreya027 force-pushed the upgrade-branch branch from a057443 to fa4f247 Compare February 2, 2022 21:27

Shreya027 requested a review from cgchinmay February 2, 2022 21:27

cgchinmay reviewed Feb 2, 2022

View reviewed changes

Remove Printf stmts

a2e3783

Shreya027 requested a review from cgchinmay February 2, 2022 23:05

cgchinmay reviewed Feb 3, 2022

View reviewed changes

cgchinmay reviewed Feb 4, 2022

View reviewed changes

Shreya Anil Naik added 2 commits February 4, 2022 16:17

Add helper func for handling wait and poll

ae11922

Add formatting changes

f6377f8

cgchinmay added a commit to cgchinmay/amazon-vpc-cni-k8s that referenced this pull request Feb 14, 2022

Refactored code

8036196

Addon upgrade/downgrade test similar to aws#1795 Added tests for addon upgrade/downgrade

cgchinmay mentioned this pull request Feb 14, 2022

Refactored code and Added cni addon upgrade/downgrade regression test #1861

Merged

cgchinmay closed this Feb 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CNI IT to test for version upgrade/downgrade #1795

CNI IT to test for version upgrade/downgrade #1795

Shreya027 commented Dec 16, 2021 •

edited

Loading

cgchinmay commented Dec 21, 2021

cgchinmay left a comment

abhipth commented Jan 13, 2022 •

edited

Loading

Shreya027 commented Jan 16, 2022 •

edited

Loading

cgchinmay commented Jan 22, 2022

cgchinmay Jan 22, 2022

Shreya027 Feb 1, 2022 •

edited

Loading

Shreya027 commented Feb 1, 2022 •

edited

Loading

cgchinmay Feb 2, 2022 •

edited

Loading

cgchinmay Feb 2, 2022

cgchinmay Feb 2, 2022

cgchinmay Feb 3, 2022 •

edited

Loading

cgchinmay Feb 4, 2022 •

edited

Loading

cgchinmay Feb 4, 2022 •

edited

Loading

cgchinmay Feb 4, 2022

cgchinmay left a comment •

edited

Loading

cgchinmay commented Feb 14, 2022

CNI IT to test for version upgrade/downgrade #1795

CNI IT to test for version upgrade/downgrade #1795

Conversation

Shreya027 commented Dec 16, 2021 • edited Loading

cgchinmay commented Dec 21, 2021

cgchinmay left a comment

Choose a reason for hiding this comment

abhipth commented Jan 13, 2022 • edited Loading

Shreya027 commented Jan 16, 2022 • edited Loading

cgchinmay commented Jan 22, 2022

cgchinmay Jan 22, 2022

Choose a reason for hiding this comment

Shreya027 Feb 1, 2022 • edited Loading

Choose a reason for hiding this comment

Shreya027 commented Feb 1, 2022 • edited Loading

cgchinmay Feb 2, 2022 • edited Loading

Choose a reason for hiding this comment

cgchinmay Feb 2, 2022

Choose a reason for hiding this comment

cgchinmay Feb 2, 2022

Choose a reason for hiding this comment

cgchinmay Feb 3, 2022 • edited Loading

Choose a reason for hiding this comment

cgchinmay Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

cgchinmay Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

cgchinmay Feb 4, 2022

Choose a reason for hiding this comment

cgchinmay left a comment • edited Loading

Choose a reason for hiding this comment

cgchinmay commented Feb 14, 2022

Shreya027 commented Dec 16, 2021 •

edited

Loading

abhipth commented Jan 13, 2022 •

edited

Loading

Shreya027 commented Jan 16, 2022 •

edited

Loading

Shreya027 Feb 1, 2022 •

edited

Loading

Shreya027 commented Feb 1, 2022 •

edited

Loading

cgchinmay Feb 2, 2022 •

edited

Loading

cgchinmay Feb 3, 2022 •

edited

Loading

cgchinmay Feb 4, 2022 •

edited

Loading

cgchinmay Feb 4, 2022 •

edited

Loading

cgchinmay left a comment •

edited

Loading