Enable controller to be aware of number of available IP addresses #23
Conversation
|
This plugin is usable outside of an eks cluster so the resource should not be scoped to eks. Maybe vpc-cni.amazon.com/ip or vpc-cni.aws.amazon.com/ip? |
|
I second @mattlandis comment here. Also, if you have 3611 files in a single commit, it's impossible for anyone to review it effectively. |
|
I am not sure if this resource would ever make sense outside of EKS. If we name it generically, we risk confusing people who do not need it into thinking they do. This resource exists only because a specific implementation detail of vpc-cni-k8s plugin requires it. Other CNI plugins (at least as of today) do not need it. Also, the name of the resource should be something like "private-ipv4-address". "ip" is the name of the protocol, and even if it is commonly (and incorrectly) understood to be an address, let's be clear on what type of address it really is. |
|
We deploy a custom-configured Kubernetes cluster on EC2 and would love to have this feature generically available instead of tied directly to EKS. |
|
how about |
|
how about |
| @@ -21,13 +21,17 @@ | |||
| # version = "2.4.0" | |||
|
|
|||
|
|
|||
| [[constraint]] | |||
| name = "github.com/aws/amazon-ecs-agent" | |||
There was a problem hiding this comment.
Right now, it uses some code from amazon-ecs-agent and amazon-ecs-cni-plugins. We are planning to move these shared code out into another library repo and only vendor this new library repo.
There was a problem hiding this comment.
What code are you using? It's worth evaluating whether to factor it out or to just stop using the code; not everything in the ECS agent is code that we'd recommend reusing.
There was a problem hiding this comment.
opened issue #27 to track this. Thanks
| revision = "ea58fddf8462034ff2034aa9788b02341d7702e3" | ||
| version = "v1.15.2" | ||
| revision = "ea383f2ff70290029ee69c7089160b10941baeb6" | ||
| version = "v1.16.1" | ||
|
|
||
| [[projects]] | ||
| branch = "master" |
There was a problem hiding this comment.
Why did you vendor github.com/aws/amazon-ecs-cni-plugins?
|
Move this to a new PR #31 where it is broken down into multiple commit |
This PR addresses issue #18 .
It defines eks.amazon.com/ip as a kubernetes' extended resources to represent the number of available of available IP addresses on each node.