Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make generate, make generate-limits, and remove soak tests #2819

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

jdn5126
Copy link
Contributor

@jdn5126 jdn5126 commented Feb 29, 2024

What type of PR is this?
cleanup

Which issue does this PR fix?:

N/A

What does this PR do / Why do we need it?:
This PR does the following:

  1. Runs make generate to update generated files.
  2. Runs make generate-limits to update instance limits.
  3. Removes the soak integration test suite, as the checkpoint migration has been completed and this suite is no longer relevant.

One thing to call out is how significant the changes in rpc/rpc.pb.go are. These come from running: protoc --go_out=plugins=grpc,paths=source_relative:. rpc.proto with protoc version libprotoc 3.15.8. From review, these changes look correct and safe to me.

Testing done on this change:
All unit tests and integration tests pass.

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:
Yes

Updates instance limits and generated RPC code

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jdn5126 jdn5126 requested a review from a team as a code owner February 29, 2024 17:37
@orsenthil
Copy link
Member

One thing to call out is how significant the changes in rpc/rpc.pb.go are. These come from running: protoc --go_out=plugins=grpc,paths=source_relative:. rpc.proto with protoc version libprotoc 3.15.8. From review, these changes look correct and safe to me.

Agree.

For auto-generated code, relying on Integration tests are the best.

Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil orsenthil merged commit 482d4fb into aws:master Mar 1, 2024
6 checks passed
@jdn5126 jdn5126 deleted the cleanup branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants