Make vpc cni as master CNI in multus-daemonset-thick.yml #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdn5126
approved these changes
Mar 1, 2024
jdn5126
force-pushed
the
master
branch
2 times, most recently
from
0814244
to
6bdaa20
Compare
Make vpc cni as master CNI in multus-daemonset-thick.yml, to avooid multus selecting any other cni as primary
orsenthil
approved these changes
Mar 1, 2024
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make vpc cni as master CNI in multus-daemonset-thick.yml, to avooid multus selecting any other cni as primary
What type of PR is this?
improvement
Which issue does this PR fix?:
#2767
What does this PR do / Why do we need it?:
Testing done on this change:
#2767 (comment)
Also validated with deployment of istio cni
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
This change shall not break upgrades, as its a supported config change. Besides this fix is to ensure that vpc-cni is master CNI
Does this change require updates to the CNI daemonset config files to work?:
Not the vpc cni , its an additional configuration for Multus which uses vpc-cni
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.