Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing params to authorize ingress #2849

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

jchen6585
Copy link
Contributor

What type of PR is this?

bug

Which issue does this PR fix?:

N/A

What does this PR do / Why do we need it?:
SGPP+CNW test suite is missing a parameter when calling AuthorizeSecurityGroupIngress

Testing done on this change:

N/A

Will this PR introduce any new dependencies?:

No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:

No

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jchen6585 jchen6585 requested a review from a team as a code owner March 14, 2024 17:28
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jchen6585 jchen6585 merged commit 192c8e5 into aws:master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants