Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go dependency with go-cose library. #2905

Closed
wants to merge 2 commits into from
Closed

Conversation

orsenthil
Copy link
Member

What type of PR is this?

This indirect dependency was causing reference failures in IntelliJ.

Which issue does this PR fix?:

go list -modfile=go.mod -m -json -mod=go.mod all #gosetup

fails with

go: github.com/veraison/go-cose@v1.2.0: invalid version: unknown revision v1.2.0

As older modules are retracted

https://pkg.go.dev/github.com/veraison/go-cose?tab=versions

And this needs to be pinned to v1.1.0

What does this PR do / Why do we need it?:

So that go list is successful.

{
	"Path": "github.com/veraison/go-cose",
	"Version": "v1.2.0",
	"Replace": {
		"Path": "github.com/veraison/go-cose",
		"Version": "v1.1.0",
		"Time": "2023-05-18T12:32:47Z",
		"GoMod": "/Users/senthilx/go/pkg/mod/cache/download/github.com/veraison/go-cose/@v/v1.1.0.mod",
		"GoVersion": "1.18"
	},
	"Indirect": true,
	"GoMod": "/Users/senthilx/go/pkg/mod/cache/download/github.com/veraison/go-cose/@v/v1.1.0.mod",
	"GoVersion": "1.18"
}

@orsenthil orsenthil requested a review from a team as a code owner May 3, 2024 14:13
@orsenthil orsenthil mentioned this pull request May 7, 2024
2 tasks
@orsenthil
Copy link
Member Author

No need. As the change was introduced in #2895

@orsenthil orsenthil closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant