Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/client-go from 0.30.3 to 0.31.1 #3036

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2024

Bumps k8s.io/client-go from 0.30.3 to 0.31.1.

Commits
  • c5196eb Update dependencies to v0.31.1 tag
  • 5e3e8ea informers: add comment that Start does not block
  • f71a5cc Call non-blocking informerFactory.Start synchronously to avoid races
  • 4536e5a Merge pull request #124012 from Jefftree/le-controller
  • 93c6a5b Merge pull request #126353 from liggitt/fix-vendor
  • 6a9911a revendor dependencies
  • fe54892 Merge pull request #126243 from SergeyKanzhelev/devicePluginFailures
  • 825f52e Change PingTime to be persistent
  • f45c451 fix ordering issue in candidates
  • 18dd587 feedback: leasecandidate clients
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner September 24, 2024 21:32
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 24, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.31.1 branch 2 times, most recently from 8445cac to 4e5929b Compare September 24, 2024 22:23
@orsenthil
Copy link
Member

Looks like Dependencies are failing for this PR.

This change has to be updated last.

There are errors with the provided package patterns:

Error: /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/internal/controller/controller.go:103:10: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})
Error: /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/webhook/admission/webhook.go:158:10: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})
Error: /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/client/fake/client.go:858:29: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to dryPatch: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
		have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
		want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error
Error: /home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.18.4/pkg/client/fake/client.go:872:37: cannot use c.tracker (variable of type versionedTracker) as "k8s.io/client-go/testing".ObjectTracker value in argument to testing.ObjectReaction: versionedTracker does not implement "k8s.io/client-go/testing".ObjectTracker (wrong type for method Create)
		have Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string) error
		want Create("k8s.io/apimachinery/pkg/runtime/schema".GroupVersionResource, "k8s.io/apimachinery/pkg/runtime".Object, string, ..."k8s.io/apimachinery/pkg/apis/meta/v1".CreateOptions) error

For details on package patterns, see https://pkg.go.dev/cmd/go#hdr-Package_lists_and_patterns.

Error: Process completed with exit code 1.

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.31.1 branch 2 times, most recently from eed0c58 to 15ceee9 Compare September 25, 2024 19:14
@orsenthil
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.31.1 branch 3 times, most recently from 806586c to 7a7dd17 Compare October 1, 2024 16:51
@orsenthil
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.31.1 branch from 7a7dd17 to e23d2c2 Compare October 8, 2024 21:07
@orsenthil
Copy link
Member

@dependabot recreate

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.30.3 to 0.31.1.
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.30.3...v0.31.1)

---
updated-dependencies:
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/k8s.io/client-go-0.31.1 branch from e23d2c2 to fe16768 Compare October 15, 2024 15:36
@orsenthil
Copy link
Member

Controller Runtime update was required for this PR
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.19.0

Copy link
Contributor

@sushrk sushrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil orsenthil merged commit c5eecf5 into master Oct 16, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/client-go-0.31.1 branch October 16, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants