Skip to content

Commit

Permalink
code build
Browse files Browse the repository at this point in the history
  • Loading branch information
karenc-bq committed Apr 16, 2024
1 parent c98f86b commit a84e611
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/run-integration-tests-codebuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
push:
branches:
- main
- workflow
- workflow-mysql

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
engine_version: ["lts"]
environment: ["pg_integ"]
environment: ["mysql_integ"]
runs-on: codebuild-jdbcWrapper-${{ github.run_id }}-${{ github.run_attempt }}
environment: ${{ matrix.environment }}
steps:
Expand Down Expand Up @@ -50,15 +50,15 @@ jobs:
echo "TEMP_AWS_SESSION_TOKEN=${creds[2]}" >> $GITHUB_ENV
- name: Run integration tests
run: |
./gradlew --no-parallel --no-daemon test-all-aurora
./gradlew --no-parallel --no-daemon test-all-mysql-aurora
env:
AURORA_CLUSTER_DOMAIN: ${{ secrets.DB_CONN_SUFFIX }}
AURORA_DB_REGION: ${{ secrets.AWS_DEFAULT_REGION }}
AWS_ACCESS_KEY_ID: ${{ env.TEMP_AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ env.TEMP_AWS_SECRET_ACCESS_KEY }}
AWS_SESSION_TOKEN: ${{ env.TEMP_AWS_SESSION_TOKEN }}
RDS_ENDPOINT: ${{ secrets.RDS_ENDPOINT }}
AURORA_MYSQL_DB_ENGINE_VERSION: ${{ matrix.engine_version }}
AURORA_MYSQL_DB_ENGINE_VERSION: ${{ secrets.engine_version }}
AURORA_PG_ENGINE_VERSION: ${{ matrix.engine_version }}
- name: 'Archive junit results ${{ matrix.engine_version }}'
if: always()
Expand Down
2 changes: 2 additions & 0 deletions wrapper/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ tasks.register<Test>("test-all-pg-aurora") {
systemProperty("test-no-mysql-engine", "true")
systemProperty("test-no-mariadb-driver", "true")
systemProperty("test-no-mariadb-engine", "true")
systemProperty("test-no-graalvm", "true")
systemProperty("test-no-openjdk11", "true")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,12 +351,12 @@ public void test_setReadOnly_closedConnection() throws SQLException {
}

/**
* PG driver has check of internal readOnly flag and doesn't communicate to a DB server
* if there's no changes. Thus, network exception is not raised.
* PG driver and MariaDB driver have a check for internal readOnly flag and don't communicate to a DB server
* if there are no changes. Thus, network exception is not raised.
*/
@TestTemplate
@EnableOnTestFeature(TestEnvironmentFeatures.NETWORK_OUTAGES_ENABLED)
@DisableOnTestDriver(TestDriver.PG) // see comments above
@DisableOnTestDriver({TestDriver.PG, TestDriver.MARIADB}) // see comments above
public void test_setReadOnlyFalse_allInstancesDown() throws SQLException {
try (final Connection conn = DriverManager.getConnection(
ConnectionStringHelper.getProxyWrapperUrl(), getProxiedProps())) {
Expand Down

0 comments on commit a84e611

Please sign in to comment.