Skip to content

Conversation

@karenc-bq
Copy link
Contributor

@karenc-bq karenc-bq commented Feb 4, 2025

Summary

The Initial Connection Strategy Plugin only performs extra handling if the connection url is a cluster endpoint, otherwise it will call the next plugin immediately during connect. Same logic should apply in the initHostListProvider pipeline.

https://github.com/aws/aws-advanced-jdbc-wrapper/blob/main/docs/using-the-jdbc-driver/using-plugins/UsingTheAuroraInitialConnectionStrategyPlugin.md

Description

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@sergiyvamz
Copy link
Contributor

Can we postpone this fix till #1265 merged? I feel like this fix needs to reviewed and maybe adjusted taken into account custom domains.

@karenc-bq karenc-bq force-pushed the fix/aurora-initial-connection-strategy-plugin branch 2 times, most recently from 9a260c2 to 1644da6 Compare February 6, 2025 20:50
@karenc-bq karenc-bq force-pushed the fix/aurora-initial-connection-strategy-plugin branch from 1644da6 to 67a48f4 Compare February 11, 2025 22:53
@karenc-bq karenc-bq force-pushed the fix/aurora-initial-connection-strategy-plugin branch from f5c4b3d to cbb32c8 Compare June 13, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants