Remove flaky and unstable suggested clusterId functionality #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
force-pushed
the
feat-cluster-id
branch
from
b0b5496 to
cd1db38
Compare
changelog rebase and fix unit tests remove suggested clusterId functionality; change logic of configuration parameter clusterId.
sergiyvamz
force-pushed
the
feat-cluster-id
branch
from
cd1db38 to
6393261
Compare
sergiyvamz
added a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove flaky and unstable functionality of suggesting (i.e. guessing) of a cluster id. Use optional parameter clusterId instead.
For applications that use a single cluster database no changes are required. For application that access multiple database clusters, all connection string should be reviewed and a mandatory clusterId parameter should be added.
See clusterId parameter description at https://github.com/aws/aws-advanced-jdbc-wrapper/blob/main/docs/using-the-jdbc-driver/using-plugins/UsingTheFailover2Plugin.md
Description
remove suggested clusterId functionality
change logic of configuration parameter clusterId
Additional Reviewers
@karenc-bq
@aaron-congo
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.