feat: add support of RDS Proxy custom endpoints #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Oct 28, 2025
Comment on lines
+428
to
+429
| } else if (isRdsProxyEndpointDns(host)) { | ||
| return RdsUrlType.RDS_PROXY_ENDPOINT; |
Contributor
There was a problem hiding this comment.
Curious why do we need these? Do the existing isRdsProxyDns and RDS_PROXY not cover the same cases? Could we remove one of these?
Contributor
Author
There was a problem hiding this comment.
Some of our plugins are not compatible with RDS Proxy so it's important to properly recognize all type of urls related to RDS Proxy. we can reuse the same RDS_PROXY but I think it's better to be precise.
sophia-bq
approved these changes
Oct 29, 2025
karenc-bq
reviewed
Oct 30, 2025
karenc-bq
approved these changes
Oct 30, 2025
sergiyvamz
force-pushed
the
feat-rds-proxy-endpoints
branch
from
04ad6c1 to
e12ca0a
Compare
sergiyvamz
added a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add support of RDS Proxy custom endpoints
Additional Reviewers
@karenc-bq
@aaron-congo
@sophia-bq
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.